chrome/browser/extensions/extension_prefs_scope.h - Issue 7065033: Support persistent incognito preferences

Side by Side Diff: chrome/browser/extensions/extension_prefs_scope.h

Issue 7065033: Support persistent incognito preferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed a unit test Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/extension_preference_api.cc ('K') | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_SCOPE_H_

	6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_SCOPE_H_

	7 #pragma once

	8

	9 namespace extension_prefs_scope {
	Matt Perry 2011/05/24 21:04:56 This should not be a namespace. See this discussio This should not be a namespace. See this discussion on chromium-dev http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre... I'd say you can just make it a member of either the ExtensionPrefs or ExtensionPrefValueMap class. battre 2011/05/25 11:31:45 Both would be a layering violation. - ExtensionPre Show quoted text On 2011/05/24 21:04:56, Matt Perry wrote: > This should not be a namespace. See this discussion on chromium-dev > http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre... > > I'd say you can just make it a member of either the ExtensionPrefs or > ExtensionPrefValueMap class. Both would be a layering violation. - ExtensionPrefValueMap is an implementation detail that should not be visible to consumers of ExtensionPrefs. - ExtensionPrefs on the other hand builds upon ExtensionPrefValueMap and therefore should not be required for ExtensionPrefValueMap. I have taken a note and propose to discuss this afterwards. After all it is just an implementation detail that is not visible to the outside. Bernhard Bauer 2011/05/25 17:48:34 How about just calling it ExtensionPrefScope? Show quoted text On 2011/05/25 11:31:45, battre wrote: > On 2011/05/24 21:04:56, Matt Perry wrote: > > This should not be a namespace. See this discussion on chromium-dev > > > http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre... > > > > I'd say you can just make it a member of either the ExtensionPrefs or > > ExtensionPrefValueMap class. > > Both would be a layering violation. > - ExtensionPrefValueMap is an implementation detail that should not be visible > to consumers of ExtensionPrefs. > - ExtensionPrefs on the other hand builds upon ExtensionPrefValueMap and > therefore should not be required for ExtensionPrefValueMap. > > I have taken a note and propose to discuss this afterwards. After all it is just > an implementation detail that is not visible to the outside. How about just calling it ExtensionPrefScope? Matt Perry 2011/05/25 18:40:42 Please add a TODO(battre) in that case. Show quoted text On 2011/05/25 11:31:45, battre wrote: > On 2011/05/24 21:04:56, Matt Perry wrote: > > This should not be a namespace. See this discussion on chromium-dev > > > http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre... > > > > I'd say you can just make it a member of either the ExtensionPrefs or > > ExtensionPrefValueMap class. > > Both would be a layering violation. > - ExtensionPrefValueMap is an implementation detail that should not be visible > to consumers of ExtensionPrefs. > - ExtensionPrefs on the other hand builds upon ExtensionPrefValueMap and > therefore should not be required for ExtensionPrefValueMap. > > I have taken a note and propose to discuss this afterwards. After all it is just > an implementation detail that is not visible to the outside. Please add a TODO(battre) in that case. battre 2011/05/25 19:47:44 Done. Show quoted text On 2011/05/25 18:40:42, Matt Perry wrote: > On 2011/05/25 11:31:45, battre wrote: > > On 2011/05/24 21:04:56, Matt Perry wrote: > > > This should not be a namespace. See this discussion on chromium-dev > > > > > > http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre... > > > > > > I'd say you can just make it a member of either the ExtensionPrefs or > > > ExtensionPrefValueMap class. > > > > Both would be a layering violation. > > - ExtensionPrefValueMap is an implementation detail that should not be visible > > to consumers of ExtensionPrefs. > > - ExtensionPrefs on the other hand builds upon ExtensionPrefValueMap and > > therefore should not be required for ExtensionPrefValueMap. > > > > I have taken a note and propose to discuss this afterwards. After all it is > just > > an implementation detail that is not visible to the outside. > > Please add a TODO(battre) in that case. Done.
	10

	11 // Scope for a preference.

	12 enum Scope {

	13 // Regular profile.

	14 kRegular,

	15 // Incognito profile; preference is persisted to disk and remains active

	16 // after a browser restart.

	17 kIncognitoPersistent,

	18 // TODO(battre): add kIncognitoSession

	19 };

	20

	21 } // extension_prefs_scope

	22

	23 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_SCOPE_H_

OLD	NEW