Issue 7065013: Makes Background only create a brush when needed. This avoids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7065013: Makes Background only create a brush when needed. This avoids (Closed)

Created:
9 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Makes Background only create a brush when needed. This avoids irrelevant DCHECKs if you use a color with alpha. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86454

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	views/background.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	views/background.cc	View		1 chunk	+8 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM http://codereview.chromium.org/7065013/diff/1/views/background.cc File views/background.cc (right): http://codereview.chromium.org/7065013/diff/1/views/background.cc#newcode77 views/background.cc:77: DeleteObject(native_control_brush_); Should this also set native_control_brush_ back to ...

9 years, 7 months ago (2011-05-24 02:09:48 UTC) #2

sky

9 years, 7 months ago (2011-05-24 18:13:50 UTC) #3

http://codereview.chromium.org/7065013/diff/1/views/background.cc
File views/background.cc (right):

http://codereview.chromium.org/7065013/diff/1/views/background.cc#newcode77
views/background.cc:77: DeleteObject(native_control_brush_);
On 2011/05/24 02:09:48, Ben Goodger wrote:
> Should this also set native_control_brush_ back to NULL so it gets
regenerated?

Definitely. Fixed.

Expand Messages | Collapse Messages