Makes Background only create a brush when needed. This avoids

views/background.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/background.h"
 
 #include "base/logging.h"
 #include "skia/ext/skia_utils_win.h"
 #include "third_party/skia/include/core/SkPaint.h"
 #include "ui/gfx/canvas_skia.h"
@@ skipping 56 matching lines @@
 
 Background::~Background() {
 #if defined(OS_WIN)
   DeleteObject(native_control_brush_);
 #endif
 }
 
 void Background::SetNativeControlColor(SkColor color) {
   color_ = color;
 #if defined(OS_WIN)
   DeleteObject(native_control_brush_);

[Ben Goodger (Google), 2011/05/24 02:09:48]

Should this also set native_control_brush_ back to NULL so it gets regenerated?

[sky, 2011/05/24 18:13:50]

Definitely. Fixed.

-  native_control_brush_ = CreateSolidBrush(skia::SkColorToCOLORREF(color));
 #endif
 }
 
+#if defined(OS_WIN)
+HBRUSH Background::GetNativeControlBrush() const {
+  if (!native_control_brush_)
+    native_control_brush_ = CreateSolidBrush(skia::SkColorToCOLORREF(color_));
+  return native_control_brush_;
+}
+#endif
+
 //static
 Background* Background::CreateSolidBackground(const SkColor& color) {
   return new SolidBackground(color);
 }
 
 //static
 Background* Background::CreateStandardPanelBackground() {
   return CreateVerticalGradientBackground(SkColorSetRGB(246, 250, 255),
                                           SkColorSetRGB(219, 235, 255));
 }
 
 //static
 Background* Background::CreateVerticalGradientBackground(
     const SkColor& color1, const SkColor& color2) {
   Background* background = CreateBackgroundPainter(
       true, Painter::CreateVerticalGradient(color1, color2));
   background->SetNativeControlColor(
       color_utils::AlphaBlend(color1, color2, 128));
 
   return background;
 }
 
 //static
 Background* Background::CreateBackgroundPainter(bool owns_painter,
                                                 Painter* painter) {
   return new BackgroundPainter(owns_painter, painter);
 }
 
 }  // namespace views