Change printing of PDFs for preview on Windows to not rasterize.

Change printing of PDFs for preview on Windows to not rasterize.

Also cleaned up a few hacks.

BUG=80220
TEST=Navigate to a PDF and start print preview.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86431

[Lei Zhang, 2011-05-24 00:24:16]

LGTM, with some nits below.

http://codereview.chromium.org/7065011/diff/1008/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/7065011/diff/1008/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_win.cc:164: // allocating buffers.
please just make this comment a bit clearer.

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1135:
if(printing::MetafileSkiaWrapper::GetMetafileFromCanvas(canvas)) {
nit: space after if.

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1323: if (metafile) {
maybe just add a quick comment to say this is the print preview case.

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.h (right):

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.h:381: // When printing to print
preview (PDF output), all pages need to be written
This comment isn't 100% correct. Regular printing on Linux does this too.

[vandebo (ex-Chrome), 2011-05-24 05:48:37]

http://codereview.chromium.org/7065011/diff/1008/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/7065011/diff/1008/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_win.cc:164: // allocating buffers.
On 2011/05/24 00:24:16, Lei Zhang wrote:
> please just make this comment a bit clearer.

Done.

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1135:
if(printing::MetafileSkiaWrapper::GetMetafileFromCanvas(canvas)) {
On 2011/05/24 00:24:16, Lei Zhang wrote:
> nit: space after if.

Done.

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1323: if (metafile) {
On 2011/05/24 00:24:16, Lei Zhang wrote:
> maybe just add a quick comment to say this is the print preview case.

Done.

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.h (right):

http://codereview.chromium.org/7065011/diff/1008/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.h:381: // When printing to print
preview (PDF output), all pages need to be written
On 2011/05/24 00:24:16, Lei Zhang wrote:
> This comment isn't 100% correct. Regular printing on Linux does this too.

Done.

[Lei Zhang, 2011-05-24 06:22:23]

+sanjeevr since he was interested in this.