Change printing of PDFs for preview on Windows to not rasterize.

webkit/plugins/ppapi/ppapi_plugin_instance.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 #define WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "googleurl/src/gurl.h"
 #include "ppapi/c/dev/pp_cursor_type_dev.h"
 #include "ppapi/c/dev/ppp_graphics_3d_dev.h"
 // TODO(dmichael): Remove the 0.3 printing interface and remove the following
 //                 #define.
 #define PPP_PRINTING_DEV_USE_0_4 1
 #include "ppapi/c/dev/ppp_printing_dev.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_resource.h"
 #include "third_party/skia/include/core/SkBitmap.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebCanvas.h"
 #include "ui/gfx/rect.h"
 #include "webkit/plugins/ppapi/plugin_delegate.h"
 
 typedef struct NPObject NPObject;
 struct PP_Var;
 struct PPB_Instance;
 struct PPB_Instance_Private;
 struct PPB_Find_Dev;
 struct PPB_Fullscreen_Dev;
@@ skipping 331 matching lines @@
   bool checked_for_plugin_messaging_interface_;
 
   // This is only valid between a successful PrintBegin call and a PrintEnd
   // call.
   PP_PrintSettings_Dev current_print_settings_;
 #if defined(OS_MACOSX)
   // On the Mac, when we draw the bitmap to the PDFContext, it seems necessary
   // to keep the pixels valid until CGContextEndPage is called. We use this
   // variable to hold on to the pixels.
   scoped_refptr<PPB_ImageData_Impl> last_printed_page_;
-#elif defined(OS_LINUX)
-  // On Linux, all pages need to be written to a PDF file in one shot. However,
-  // when users print only a subset of all the pages, it is impossible to know
-  // if a call to PrintPage() is the last call. Thus in PrintPage(), just store
-  // the page number in |ranges_|.
+#endif  // defined(OS_MACOSX)
+#if WEBKIT_USING_SKIA
+  // When printing to print preview (PDF output), all pages need to be written

[Lei Zhang, 2011/05/24 00:24:16]

This comment isn't 100% correct. Regular printing on Linux does this too.

[vandebo (ex-Chrome), 2011/05/24 05:48:38]

Done.

+  // to a file in one shot. However, when users print only a subset of all the
+  // pages, it is impossible to know if a call to PrintPage() is the last call.
+  // Thus in PrintPage(), just store the page number in |ranges_|.
   // The hack is in PrintEnd(), where a valid |canvas_| is preserved in
   // PrintWebViewHelper::PrintPages. This makes it possible to generate the
   // entire PDF given the variables below:
   //
   // The most recently used WebCanvas, guaranteed to be valid.
-  WebKit::WebCanvas* canvas_;
+  SkRefPtr<WebKit::WebCanvas> canvas_;
   // An array of page ranges.
   std::vector<PP_PrintPageNumberRange_Dev> ranges_;
-#endif  // defined(OS_LINUX)
+#endif  // WEBKIT_USING_SKIA
 
   // The plugin print interface.  This nested struct adds functions needed for
   // backwards compatibility.
   struct PPP_Printing_Dev_Combined : public PPP_Printing_Dev {
     // Conversion constructor for the most current interface.  Sets all old
     // functions to NULL, so we know not to try to use them.
     PPP_Printing_Dev_Combined(const PPP_Printing_Dev& base_if)
         : PPP_Printing_Dev(base_if),
           QuerySupportedFormats_0_3(NULL),
           Begin_0_3(NULL) {}
@@ skipping 52 matching lines @@
   typedef std::map<NPObject*, ObjectVar*> NPObjectToObjectVarMap;
   NPObjectToObjectVarMap np_object_to_object_var_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginInstance);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_