Issue 7064038: ExtensionApiTest.Notifications: wait until part 1 finishes cleanup before going to part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7064038: ExtensionApiTest.Notifications: wait until part 1 finishes cleanup before going to part 2 (Closed)

Created:
9 years, 7 months ago by Ben Olmstead

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ExtensionApiTest.Notifications: wait until part 1 finishes cleanup before going to part 2. Fixes flake. Without change: 18 failures out of 250 runs on my machine. 3 out of 250 on Linux try bot. With change: 0 failures out of 250 runs on my machine. 0 out of 250 on Linux try bot. TEST=Run ExtensionApiTest.Notifications many times. BUG=42314 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86682

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
M	chrome/browser/extensions/notifications_apitest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/notifications/has_permission_prefs/notification.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Try job failure for 7064038-1 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=28710

9 years, 7 months ago (2011-05-24 23:12:52 UTC) #3

Change committed as 86682

Expand Messages | Collapse Messages