chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html - Issue 7064038: ExtensionApiTest.Notifications: wait until part 1 finishes cleanup before going to part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html

Issue 7064038: ExtensionApiTest.Notifications: wait until part 1 finishes cleanup before going to part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/notifications_apitest.cc ('k') | chrome/test/data/extensions/api_test/notifications/has_permission_prefs/notification.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html

diff --git a/chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html b/chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html

index d78435558421860b503b2a2677bc9ad2865a4096..e58b14bd7548099a9719f2e455a6d59334d01188 100644

--- a/chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html

+++ b/chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html

@@ -12,11 +12,13 @@ function showNotification(url) {

}

// Called by the notification when it is done with its tests.

-function onNotificationDone() {

+function onNotificationDone(notificationWindow) {

var views = chrome.extension.getViews();

chrome.test.assertEq(2, views.length);

+ notificationWindow.onunload = function() {

+ chrome.test.succeed();

+ }

notification.cancel();

- chrome.test.succeed();

}

chrome.test.runTests([