Issue 7064035: Use the non-touch popup frame instead of NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7064035: Use the non-touch popup frame instead of NULL. (Closed)

Created:
9 years, 7 months ago by sadrul

Modified:
9 years, 6 months ago

Reviewers:
sky, Alex Nicolaou

CC:
chromium-reviews, Yufeng Shen (Slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use the non-touch popup frame instead of NULL. While this change isn't really all that usable in chrome itself, it fixes a number of the tests in browser_tests and ui_tests, and fixes a crash in some other tests to unmask other failures. BUG=none TEST=some failing tests (e.g. BrowserNavigatorTest.*) should pass on the touch buildbot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86530

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc	View		2 chunks	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/7064035/diff/1/chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc File chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc (right): http://codereview.chromium.org/7064035/diff/1/chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc#newcode18 chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc:18: NOTIMPLEMENTED(); Is the NOTIMPLEMENTED still relevant now?

9 years, 7 months ago (2011-05-24 17:31:06 UTC) #2

sadrul

9 years, 7 months ago (2011-05-24 17:33:28 UTC) #3

http://codereview.chromium.org/7064035/diff/1/chrome/browser/ui/touch/frame/b...
File
chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc
(right):

http://codereview.chromium.org/7064035/diff/1/chrome/browser/ui/touch/frame/b...
chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc:18:
NOTIMPLEMENTED();
On 2011/05/24 17:31:06, sky wrote:
> Is the NOTIMPLEMENTED still relevant now?

I kept it here just to make sure we get the log message telling us we still have
a TODO.

Expand Messages | Collapse Messages