Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7537)

Unified Diff: chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc

Issue 7064035: Use the non-touch popup frame instead of NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc
diff --git a/chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc b/chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc
index de4e0effb9b5a4f51ef768639c8b3f1d72d80bd1..fa5e270571b0e04171a6745c08d3d5c92df2d302 100644
--- a/chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc
+++ b/chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/ui/touch/frame/touch_browser_frame_view.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/frame/popup_non_client_frame_view.h"
namespace browser {
@@ -15,7 +16,7 @@ BrowserNonClientFrameView* CreateBrowserNonClientFrameView(
browser_view->IsBrowserTypePanel()) {
// TODO(anicolao): implement popups for touch
NOTIMPLEMENTED();
sky 2011/05/24 17:31:06 Is the NOTIMPLEMENTED still relevant now?
sadrul 2011/05/24 17:33:28 I kept it here just to make sure we get the log me
- return NULL;
+ return new PopupNonClientFrameView(frame);
} else {
return new TouchBrowserFrameView(frame, browser_view);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698