Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: net/socket_stream/socket_stream.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_server_socket_libevent.h ('k') | net/tools/flip_server/acceptor_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream.h
diff --git a/net/socket_stream/socket_stream.h b/net/socket_stream/socket_stream.h
index 18042e0cf0be3a84325394745b93adb89dd6f261..0b1bc10994d98bdc0dcbe5545870f845689ccb80 100644
--- a/net/socket_stream/socket_stream.h
+++ b/net/socket_stream/socket_stream.h
@@ -189,7 +189,7 @@ class NET_API SocketStream : public base::RefCountedThreadSafe<SocketStream> {
std::string headers_;
private:
- ~RequestHeaders() { data_ = NULL; }
+ virtual ~RequestHeaders() { data_ = NULL; }
};
class ResponseHeaders : public IOBuffer {
@@ -202,7 +202,7 @@ class NET_API SocketStream : public base::RefCountedThreadSafe<SocketStream> {
void Realloc(size_t new_size);
private:
- ~ResponseHeaders();
+ virtual ~ResponseHeaders();
scoped_ptr_malloc<char> headers_;
};
« no previous file with comments | « net/socket/tcp_server_socket_libevent.h ('k') | net/tools/flip_server/acceptor_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698