Adding GetAudioInputDeviceNames to AudioManager, this function is supposed to do device enumerati...

media/audio/audio_device_types.h

Index: media/audio/audio_device_types.h
===================================================================
--- media/audio/audio_device_types.h	(revision 0)
+++ media/audio/audio_device_types.h	(revision 0)
@@ -0,0 +1,18 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_AUDIO_AUDIO_DEVICE_TYPES_H_
+#define MEDIA_AUDIO_AUDIO_DEVICE_TYPES_H_
+
+#include <list>

[awong, 2011/05/23 21:17:58]

This should all be in the media namespace.

[xians, 2011/05/24 13:50:27]

Done.

+#include <string>
+
+struct AudioDeviceName {

[awong, 2011/05/23 21:17:58]

BTW, this struct has non-POD data members. I think this might not pass the clang
trybots.  Give it a run through?

[xians, 2011/05/24 13:50:27]

I tried the Clang compiler, but dont have the access to run the Trybots, likely
because I am not a committer to chrome.

[awong, 2011/05/24 23:30:32]

Ah...I see.  I'll run it through the try bot for you.  If they fail, then my
expectation is that you need declare the default constructor/destructor here and
put the impelmetnation with an empty body in the .cc file.

Long explanation:

Our Clang bots have extra extensions that enforce some style + binary-reduction
rules.

In particular, non-POD datatypes inside a struct/class causes the generated
constructor/destructor to no longer be "trivial".  Instead, they can often
become inlined versions of the member constructors, which dumps a version in
each .o file that the .h is listed in.

+  std::string device_name;  // Name of the device.

[awong, 2011/05/23 21:17:58]

If this name is meant to be a display name, it should be labeled as such.

[xians, 2011/05/24 13:50:27]

Done.

+  std::string unique_id;    // Unique identifier for the device.
+};
+
+typedef std::list<AudioDeviceName> AudioDeviceNames;
+
+#endif  // MEDIA_AUDIO_AUDIO_DEVICE_TYPES_H_
Property changes on: media/audio/audio_device_types.h
___________________________________________________________________
Added: svn:eol-style
   + LF