media/audio/audio_device_types.h - Issue 7060011: Adding GetAudioInputDeviceNames to AudioManager, this function is supposed to do device enumerati...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/audio/audio_device_types.h

Issue 7060011: Adding GetAudioInputDeviceNames to AudioManager, this function is supposed to do device enumerati... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_AUDIO_AUDIO_DEVICE_TYPES_H_

	6 #define MEDIA_AUDIO_AUDIO_DEVICE_TYPES_H_

	7

	8 #include <list>
	awong 2011/05/23 21:17:58 This should all be in the media namespace. This should all be in the media namespace. xians 2011/05/24 13:50:27 Done. Show quoted text On 2011/05/23 21:17:58, awong wrote: > This should all be in the media namespace. Done.
	9 #include <string>

	10

	11 struct AudioDeviceName {
	awong 2011/05/23 21:17:58 BTW, this struct has non-POD data members. I think BTW, this struct has non-POD data members. I think this might not pass the clang trybots. Give it a run through? xians 2011/05/24 13:50:27 I tried the Clang compiler, but dont have the acce Show quoted text On 2011/05/23 21:17:58, awong wrote: > BTW, this struct has non-POD data members. I think this might not pass the clang > trybots. Give it a run through? I tried the Clang compiler, but dont have the access to run the Trybots, likely because I am not a committer to chrome. awong 2011/05/24 23:30:32 Ah...I see. I'll run it through the try bot for y Show quoted text On 2011/05/24 13:50:27, xians wrote: > On 2011/05/23 21:17:58, awong wrote: > > BTW, this struct has non-POD data members. I think this might not pass the > clang > > trybots. Give it a run through? > > I tried the Clang compiler, but dont have the access to run the Trybots, likely > because I am not a committer to chrome. Ah...I see. I'll run it through the try bot for you. If they fail, then my expectation is that you need declare the default constructor/destructor here and put the impelmetnation with an empty body in the .cc file. Long explanation: Our Clang bots have extra extensions that enforce some style + binary-reduction rules. In particular, non-POD datatypes inside a struct/class causes the generated constructor/destructor to no longer be "trivial". Instead, they can often become inlined versions of the member constructors, which dumps a version in each .o file that the .h is listed in.
	12 std::string device_name; // Name of the device.
	awong 2011/05/23 21:17:58 If this name is meant to be a display name, it sho If this name is meant to be a display name, it should be labeled as such. xians 2011/05/24 13:50:27 Done. Show quoted text On 2011/05/23 21:17:58, awong wrote: > If this name is meant to be a display name, it should be labeled as such. Done.
	13 std::string unique_id; // Unique identifier for the device.

	14 };

	15

	16 typedef std::list<AudioDeviceName> AudioDeviceNames;

	17

	18 #endif // MEDIA_AUDIO_AUDIO_DEVICE_TYPES_H_

OLD	NEW

« no previous file with comments | « no previous file | media/audio/audio_input_device_unittest.cc » ('j') | media/audio/audio_input_device_unittest.cc » ('J')