Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7060005: Experimental i18n extension breaks shared library build. Revert recent (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev, Nebojša Ćirić
Visibility:
Public.

Description

Experimental i18n extension breaks shared library build. Revert recent changes to unblock V8 release. Revert "Adding DateTimeFormat class to i18n API with following methods:" Revert "Some internal methods are requested when v8 is built as DLL (V8_SHARED), and" R=sgjesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -615 lines) Patch
D src/extensions/experimental/datetime-format.h View 1 chunk +0 lines, -83 lines 0 comments Download
D src/extensions/experimental/datetime-format.cc View 1 chunk +0 lines, -381 lines 0 comments Download
M src/extensions/experimental/experimental.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/extensions/experimental/i18n.js View 7 chunks +11 lines, -98 lines 0 comments Download
M src/extensions/experimental/i18n-extension.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M src/extensions/experimental/i18n-utils.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/extensions/experimental/i18n-utils.cc View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 7 months ago (2011-05-23 08:29:29 UTC) #1
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-23 08:35:05 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698