Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: src/extensions/experimental/i18n-utils.cc

Issue 7060005: Experimental i18n extension breaks shared library build. Revert recent (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/extensions/experimental/i18n-utils.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 11 matching lines...) Expand all
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "i18n-utils.h" 28 #include "i18n-utils.h"
29 29
30 #include <string.h> 30 #include <string.h>
31 31
32 #include "unicode/unistr.h"
33
34 namespace v8 { 32 namespace v8 {
35 namespace internal { 33 namespace internal {
36 34
37 // static 35 // static
38 void I18NUtils::StrNCopy(char* dest, int length, const char* src) { 36 void I18NUtils::StrNCopy(char* dest, int length, const char* src) {
39 if (!dest || !src) return; 37 if (!dest || !src) return;
40 38
41 strncpy(dest, src, length); 39 strncpy(dest, src, length);
42 dest[length - 1] = '\0'; 40 dest[length - 1] = '\0';
43 } 41 }
44 42
45 // static
46 bool I18NUtils::ExtractStringSetting(const v8::Handle<v8::Object>& settings,
47 const char* setting,
48 icu::UnicodeString* result) {
49 if (!setting || !result) return false;
50
51 v8::HandleScope handle_scope;
52 v8::TryCatch try_catch;
53 v8::Handle<v8::Value> value = settings->Get(v8::String::New(setting));
54 if (try_catch.HasCaught()) {
55 return false;
56 }
57 // No need to check if |value| is empty because it's taken care of
58 // by TryCatch above.
59 if (!value->IsUndefined() && !value->IsNull() && value->IsString()) {
60 v8::String::Utf8Value utf8_value(value);
61 if (*utf8_value == NULL) return false;
62 result->setTo(icu::UnicodeString::fromUTF8(*utf8_value));
63 return true;
64 }
65 return false;
66 }
67
68 } } // namespace v8::internal 43 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/extensions/experimental/i18n-utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698