Issue 7059019: Ensure that PageID's of prerendered pages do not exceed the Page ID of the

Issue 7059019: Ensure that PageID's of prerendered pages do not exceed the Page ID of the (Closed)

Created:
9 years, 7 months ago by tburkard

Modified:
9 years, 7 months ago

Reviewers:
dominich

CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Ensure that PageID's of prerendered pages do not exceed the Page ID of the current tab where they are swapped in. R=dominich@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86299

Patch Set 4 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
M	chrome/browser/prerender/prerender_contents.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View	1 2	2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/prerender/prerender_final_status.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_manager.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dominich

http://codereview.chromium.org/7059019/diff/4002/chrome/browser/prerender/prerender_contents.cc File chrome/browser/prerender/prerender_contents.cc (right): http://codereview.chromium.org/7059019/diff/4002/chrome/browser/prerender/prerender_contents.cc#newcode267 chrome/browser/prerender/prerender_contents.cc:267: if (starting_page_id_ < 0) As -1 has a special ...

9 years, 7 months ago (2011-05-23 17:05:15 UTC) #2

tburkard

9 years, 7 months ago (2011-05-23 17:07:42 UTC) #3

dominich

9 years, 7 months ago (2011-05-23 17:17:05 UTC) #4

LGTM

On 2011/05/23 17:07:42, tburkard wrote:
>
http://codereview.chromium.org/7059019/diff/4002/chrome/browser/prerender/pre...
> File chrome/browser/prerender/prerender_contents.cc (right):
> 
>
http://codereview.chromium.org/7059019/diff/4002/chrome/browser/prerender/pre...
> chrome/browser/prerender/prerender_contents.cc:267: if (starting_page_id_ < 0)
> Page ID's should be positive.  So I just wanted to use defensive programing. 
If
> it is say -100 for whatever reason, I'd rather set it to 10 to ensure the page
> id of the prerender will be positive, rather than ignore it or crash and use
an
> invalid negative page id.

I'd prefer if this was a check against -1 with a (D)CHECK against < -1 so that
we can catch the unexpected case sooner rather than having a bug go unnoticed
for a time, but I'm not going to insist on it as it is really a matter of
preference.

> 
> On 2011/05/23 17:05:15, dominic wrote:
> > As -1 has a special meaning and we don't expect < -1, perhaps this should be
> ==
> > -1.
> 
>
http://codereview.chromium.org/7059019/diff/4002/chrome/browser/prerender/pre...
> chrome/browser/prerender/prerender_contents.cc:269: starting_page_id_ += 10;
> On 2011/05/23 17:05:15, dominic wrote:
> > Can you make this 10 a constant?
> 
> Done.

Expand Messages | Collapse Messages