Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3887)

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 7059019: Ensure that PageID's of prerendered pages do not exceed the Page ID of the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_contents.h ('k') | chrome/browser/prerender/prerender_final_status.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_contents.cc
===================================================================
--- chrome/browser/prerender/prerender_contents.cc (revision 86289)
+++ chrome/browser/prerender/prerender_contents.cc (working copy)
@@ -138,7 +138,8 @@
final_status_(FINAL_STATUS_MAX),
prerendering_has_started_(false),
child_id_(-1),
- route_id_(-1) {
+ route_id_(-1),
+ starting_page_id_(-1) {
DCHECK(prerender_manager != NULL);
}
@@ -262,11 +263,12 @@
// So that history merging will work, get the max page ID
// of the old page, and add a safety margin of 10 to it (for things
// such as redirects).
- int32 max_page_id = source_tc->GetMaxPageID();
- if (max_page_id != -1) {
- prerender_contents_->controller().set_max_restored_page_id(
- max_page_id + 10);
- }
+ starting_page_id_ = source_tc->GetMaxPageID();
+ if (starting_page_id_ < 0)
+ starting_page_id_ = 0;
+ starting_page_id_ += kPrerenderPageIdOffset;
+ prerender_contents_->controller().set_max_restored_page_id(
+ starting_page_id_);
tab_contents_delegate_.reset(new TabContentsDelegateImpl(this));
new_contents->set_delegate(tab_contents_delegate_.get());
« no previous file with comments | « chrome/browser/prerender/prerender_contents.h ('k') | chrome/browser/prerender/prerender_final_status.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698