Don't build googleurl_unittests in shlib builds.

Don't build googleurl_unittests in shlib builds.

BUG=82178
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86228

[cmp, 2011-05-21 20:47:46]

I can think of reasons we may want to keep building googleurl_unittests for
Linux shlib builds, but would like to see the shlib builder go green soon. 
Prep'ing this CL so it's ready if this is the right next step.  Evan, WDYT? 
Feel free to jump in with another fix if you have a different approach.

[Evan Martin, 2011-05-21 21:05:49]

Lgtm, thanks for fixing it! I was unaware it didn't work, I probably never
tried it

brevity due to phone
On May 21, 2011 1:47 PM, <cmp@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Message:
> I can think of reasons we may want to keep building googleurl_unittests
for
> Linux shlib builds, but would like to see the shlib builder go green soon.
> Prep'ing this CL so it's ready if this is the right next step. Evan, WDYT?
> Feel free to jump in with another fix if you have a different approach.
>
> Description:
> Don't build googleurl_unittests in shlib builds.
>
> BUG=82178
>
>
> Please review this at http://codereview.chromium.org/7059003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M build/temp_gyp/googleurl.gyp
>
>
> Index: build/temp_gyp/googleurl.gyp
> diff --git a/build/temp_gyp/googleurl.gyp b/build/temp_gyp/googleurl.gyp
> index
>
b59d994da501bd0f21a516c756cced858038eb82..682dd8e65c2afecaf8757951afc5674e66edb336

> 100644
> --- a/build/temp_gyp/googleurl.gyp
> +++ b/build/temp_gyp/googleurl.gyp
> @@ -1,4 +1,4 @@
> -# Copyright (c) 2009 The Chromium Authors. All rights reserved.
> +# Copyright (c) 2011 The Chromium Authors. All rights reserved.
> # Use of this source code is governed by a BSD-style license that can be
> # found in the LICENSE file.
>
> @@ -97,9 +97,9 @@
> }],
> # TODO(victorw): The unittest code uses inline functions that
> access
> # global variables, it also uses internal functions that we may
> not want
> - # to export, so skip building unittests for windows multi dll
> build.
> + # to export, so skip building unittests for component builds.
> # The googleurl functions are tested by the static library build.
> - ['OS=="win" and component=="shared_library"', {
> + ['component=="shared_library"', {
> 'type': 'none',
> }, {
> 'type': 'executable',
>
>