Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: build/temp_gyp/googleurl.gyp

Issue 7059003: Don't build googleurl_unittests in shlib builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyright Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/temp_gyp/googleurl.gyp
diff --git a/build/temp_gyp/googleurl.gyp b/build/temp_gyp/googleurl.gyp
index b59d994da501bd0f21a516c756cced858038eb82..682dd8e65c2afecaf8757951afc5674e66edb336 100644
--- a/build/temp_gyp/googleurl.gyp
+++ b/build/temp_gyp/googleurl.gyp
@@ -1,4 +1,4 @@
-# Copyright (c) 2009 The Chromium Authors. All rights reserved.
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -97,9 +97,9 @@
}],
# TODO(victorw): The unittest code uses inline functions that access
# global variables, it also uses internal functions that we may not want
- # to export, so skip building unittests for windows multi dll build.
+ # to export, so skip building unittests for component builds.
# The googleurl functions are tested by the static library build.
- ['OS=="win" and component=="shared_library"', {
+ ['component=="shared_library"', {
'type': 'none',
}, {
'type': 'executable',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698