Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 7058025: Switch CheckOwners to use input_api.rietveld. (Closed)

Created:
9 years, 6 months ago by M-A Ruel
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Switch CheckOwners to use input_api.rietveld. This enables private issue checking and simplifies testing. R=dpranke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87743

Patch Set 1 #

Patch Set 2 : Rebased against HEAD correctly #

Patch Set 3 : Argh, should be ok this time #

Patch Set 4 : Fix it for real this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -53 lines) Patch
M presubmit_canned_checks.py View 1 2 3 2 chunks +9 lines, -7 lines 0 comments Download
M rietveld.py View 1 chunk +0 lines, -1 line 0 comments Download
M tests/presubmit_unittest.py View 1 2 3 9 chunks +40 lines, -45 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 6 months ago (2011-06-02 18:29:57 UTC) #1
Dirk Pranke
9 years, 6 months ago (2011-06-03 01:01:52 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698