Switch CheckOwners to use input_api.rietveld.

presubmit_canned_checks.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
@@ skipping 723 matching lines @@
     return [output_api.PresubmitError(
         "OWNERS check failed: this change has no Rietveld issue number, so "
         "we can't check it for approvals.")]
 
   affected_files = set([f.LocalPath() for f in
       input_api.change.AffectedFiles(file_filter=source_file_filter)])
 
   owners_db = input_api.owners_db
   owner_email, approvers = _RietveldOwnerAndApprovers(input_api,
                                                       owners_db.email_regexp)
+  if not owner_email:
+    return [output_api.PresubmitWarning(
+        'The issue was not uploaded so you have no OWNER approval.')]
+
   approvers_plus_owner = approvers.union(set([owner_email]))
 
   missing_files = owners_db.files_not_covered_by(affected_files,
                                                  approvers_plus_owner)
   if missing_files:
     return [output_api.PresubmitError('Missing LGTM from an OWNER for: %s' %
                                       ','.join(missing_files))]
 
   if not approvers:
     return [output_api.PresubmitError('Missing LGTM from someone other than %s'
                                       % owner_email)]
   return []
 
 
 def _RietveldOwnerAndApprovers(input_api, email_regexp):
   """Return the owner and approvers of a change, if any."""
-  # TODO(dpranke): Should figure out if input_api.host_url is supposed to
-  # be a host or a scheme+host and normalize it there.
-  host = input_api.host_url
-  if not host.startswith('http://') and not host.startswith('https://'):
-    host = 'http://' + host
-  url = '%s/api/%s?messages=true' % (host, input_api.change.issue)
-  issue_props = input_api.json.load(input_api.urllib2.urlopen(url))
+  if not input_api.change.issue:
+    return None, None
+
+  issue_props = input_api.rietveld.get_issue_properties(
+      int(input_api.change.issue), True)
   owner_email = issue_props['owner_email']
 
   def match_reviewer(r):
     return email_regexp.match(r) and r != owner_email
 
   messages = issue_props.get('messages', [])
   approvers = set(
       m['sender'] for m in messages
       if m.get('approval') and match_reviewer(m['sender']))
 
@@ skipping 133 matching lines @@
     results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
         input_api, output_api, source_file_filter=text_files))
     snapshot("checking svn mime types")
     results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
         input_api, output_api))
     snapshot("checking license")
     results.extend(input_api.canned_checks.CheckLicense(
         input_api, output_api, license_header, source_file_filter=sources))
   snapshot("done")
   return results