Issue 7058001: Fixed media file API urls that are handed over to media player.

Issue 7058001: Fixed media file API urls that are handed over to media player. (Closed)

Created:
9 years, 7 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
achuithb

CC:
chromium-reviews, pam+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, achuith+watch_chromium.org, Erik does not do reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed media file API urls that are handed over to media player. BUG=chromeos-partner:3744, chromium-os:15270 TEST=make sure we can play content from file shelf with the media player Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86162

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/browser/extensions/file_manager_util.cc	View	1 2 3	2 chunks	+10 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

http://codereview.chromium.org/7058001/diff/8002/chrome/browser/extensions/file_manager_util.cc File chrome/browser/extensions/file_manager_util.cc (right): http://codereview.chromium.org/7058001/diff/8002/chrome/browser/extensions/file_manager_util.cc#newcode94 chrome/browser/extensions/file_manager_util.cc:94: std::string final_url = base_url.spec(); final_url unused. http://codereview.chromium.org/7058001/diff/8002/chrome/browser/extensions/file_manager_util.cc#newcode96 chrome/browser/extensions/file_manager_util.cc:96: *url ...

9 years, 7 months ago (2011-05-20 22:01:04 UTC) #2

achuithb

9 years, 7 months ago (2011-05-20 22:05:10 UTC) #3

LGTM

On 2011/05/20 22:01:04, achuith.bhandarkar wrote:
>
http://codereview.chromium.org/7058001/diff/8002/chrome/browser/extensions/fi...
> File chrome/browser/extensions/file_manager_util.cc (right):
> 
>
http://codereview.chromium.org/7058001/diff/8002/chrome/browser/extensions/fi...
> chrome/browser/extensions/file_manager_util.cc:94: std::string final_url =
> base_url.spec();
> final_url unused.
> 
>
http://codereview.chromium.org/7058001/diff/8002/chrome/browser/extensions/fi...
> chrome/browser/extensions/file_manager_util.cc:96: *url = GURL(base_url.spec()
+
> relative_path.Append(path).value());
> Hmm, I don't understand this. Do you think a comment would be useful here?

Expand Messages | Collapse Messages