Fixed media file API urls that are handed over to media player.

chrome/browser/extensions/file_manager_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/extensions/file_manager_util.h"
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 63 matching lines @@
       path_manager->external_provider();
   if (!provider)
     return false;
 
   // Find if this file path is managed by the external provider.
   std::vector<FilePath> root_dirs = provider->GetRootDirectories();
   for (std::vector<FilePath>::iterator iter = root_dirs.begin();
        iter != root_dirs.end();
        ++iter) {
     FilePath path;
+    std::vector<FilePath::StringType> components;
     const FilePath& root_path = *iter;
+    root_path.GetComponents(&components);
+    if (!components.size()) {
+      NOTREACHED();
+      continue;
+    }
     if (root_path.AppendRelativePath(full_file_path, &path)) {
       GURL base_url = fileapi::GetFileSystemRootURI(origin_url,
           fileapi::kFileSystemTypeExternal);
-      *url = GURL(base_url.spec() + root_path.Append(path).value().substr(1));
+      std::string final_url = base_url.spec();

[achuithb, 2011/05/20 22:01:04]

final_url unused.

+      FilePath relative_path(components[components.size() - 1]);
+      *url = GURL(base_url.spec() + relative_path.Append(path).value());

[achuithb, 2011/05/20 22:01:04]

Hmm, I don't understand this. Do you think a comment would be useful here?

       return true;
     }
   }
   return false;
 }
 
 // static
 GURL FileManagerUtil::GetFileBrowserUrlWithParams(
     SelectFileDialog::Type type,
     const string16& title,
@@ skipping 48 matching lines @@
     if (!browser)
       return;
     MediaPlayer* mediaplayer = MediaPlayer::GetInstance();
     if (enqueue)
       mediaplayer->EnqueueMediaFile(browser->profile(), full_path, NULL);
     else
       mediaplayer->ForcePlayMediaFile(browser->profile(), full_path, NULL);
     return;
   }
 
-  // Unknwon file type. Show an error message.
+  // Unknown file type. Show an error message.
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableFunction(
           &platform_util::SimpleErrorBox,
           static_cast<gfx::NativeWindow>(NULL),
           l10n_util::GetStringUTF16(IDS_FILEBROWSER_ERROR_TITLE),
           l10n_util::GetStringFUTF16(IDS_FILEBROWSER_ERROR_UNKNOWN_FILE_TYPE,
                                      UTF8ToUTF16(full_path.BaseName().value()))
           ));
 }
@@ skipping 68 matching lines @@
     case SelectFileDialog::SELECT_OPEN_MULTI_FILE:
       type_str = "open-multi-file";
       break;
 
     default:
       NOTREACHED();
   }
 
   return type_str;
 }