For extension context menus, only apply targetUrlPatterns to appropriate contexts.

For extension context menus, only apply targetUrlPatterns to appropriate contexts.

BUG=63545
TEST=Use contextMenus.create() with "page" context and targetUrlPattern; verify that menu does show.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86628

[Mihai Parparita -not on Chrome, 2011-05-24 00:28:33]

LGTM, just some style nits.

http://codereview.chromium.org/7057029/diff/2002/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/7057029/diff/2002/chrome/browser/tab_contents/...
chrome/browser/tab_contents/render_view_context_menu.cc:215: bool
RenderViewContextMenu::ExtensionContextAndPatternMatch(
Convention in this file (and in Chrome in general) is to have a "// static"
comment for static member functions.

http://codereview.chromium.org/7057029/diff/2002/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/render_view_context_menu.h (right):

http://codereview.chromium.org/7057029/diff/2002/chrome/browser/tab_contents/...
chrome/browser/tab_contents/render_view_context_menu.h:34: friend class
RenderViewContextMenuTest;
Per the Google C++ style guide "Friend declarations should always be in the
private section"

http://codereview.chromium.org/7057029/diff/2002/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/render_view_context_menu_unittest.cc (right):

http://codereview.chromium.org/7057029/diff/2002/chrome/browser/tab_contents/...
chrome/browser/tab_contents/render_view_context_menu_unittest.cc:20: virtual
void SetUp() { }
SetUp and TearDown are have no-op implementations in testing::Test, I don't
think you need to override them here.

[commit-bot: I haz the power, 2011-05-25 15:59:46]

Change committed as 86628