Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.h

Issue 7057029: For extension context menus, only apply targetUrlPatterns to appropriate contexts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update Copyright Header Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_context_menu.h
diff --git a/chrome/browser/tab_contents/render_view_context_menu.h b/chrome/browser/tab_contents/render_view_context_menu.h
index fb308ae97f11c53cb38724c84ffccb3e00cfb612..bd6bd0f0f4a3614916fd29fa8ca892afe920153e 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.h
+++ b/chrome/browser/tab_contents/render_view_context_menu.h
@@ -78,8 +78,19 @@ class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate {
std::map<int, ExtensionMenuItem::Id> extension_item_map_;
private:
+ friend class RenderViewContextMenuTest;
+
static bool IsDevToolsURL(const GURL& url);
static bool IsInternalResourcesURL(const GURL& url);
+ static bool ExtensionContextAndPatternMatch(
+ const ContextMenuParams& params,
+ ExtensionMenuItem::ContextList contexts,
+ const URLPatternSet& target_url_patterns);
+ static ExtensionMenuItem::List GetRelevantExtensionItems(
+ const ExtensionMenuItem::List& items,
+ const ContextMenuParams& params,
+ Profile* profile,
+ bool can_cross_incognito);
bool AppendCustomItems();
void AppendDeveloperItems();
void AppendLinkItems();
« no previous file with comments | « no previous file | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698