Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: webkit/blob/blob_url_request_job_unittest.cc

Issue 7056049: Changes to have chrome building with net.dll (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/blob/blob_url_request_job_unittest.cc
===================================================================
--- webkit/blob/blob_url_request_job_unittest.cc (revision 87744)
+++ webkit/blob/blob_url_request_job_unittest.cc (working copy)
@@ -69,6 +69,8 @@
private:
void ReadSome(net::URLRequest* request) {
+ // job() is not part of the URLRequest public API so it should not be
+ // used here. Bug 84783.
if (request->job()->is_done()) {
wtc 2011/06/03 18:24:40 I believe we can replace this with if (!reques
rvargas (doing something else) 2011/06/03 18:47:42 I added your comment to the bug report.
RequestComplete();
return;

Powered by Google App Engine
This is Rietveld 408576698