Changes to have chrome building with net.dll

webkit/blob/blob_url_request_job_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stack>
 #include <utility>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
@@ skipping 51 matching lines @@
        if (bytes_read > 0)
          ReceiveData(request, bytes_read);
        else
          RequestComplete();
     }
 
     const std::string& response_data() const { return response_data_; }
 
    private:
     void ReadSome(net::URLRequest* request) {
+      // job() is not part of the URLRequest public API so it should not be
+      // used here. Bug 84783.
       if (request->job()->is_done()) {

[wtc, 2011/06/03 18:24:40]

I believe we can replace this with
    if (!request->is_pending()) {

See the following code in url_request_job.cc:

void URLRequestJob::NotifyDone(const URLRequestStatus &status) {
  DCHECK(!done_) << "Job sending done notification twice";
  if (done_)
    return;
  done_ = true;
  ^^^^^^^^^^^^^

  // Unless there was an error, we should have at least tried to handle
  // the response before getting here.
  DCHECK(has_handled_response_ || !status.is_success());

  // As with NotifyReadComplete, we need to take care to notice if we were
  // destroyed during a delegate callback.
  if (request_) {
    request_->set_is_pending(false);
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...

[rvargas (doing something else), 2011/06/03 18:47:42]

I added your comment to the bug report.

         RequestComplete();
         return;
       }
 
       int bytes_read = 0;
       if (!request->Read(received_data_.get(), kBufferSize, &bytes_read)) {
         if (!request->status().is_io_pending()) {
           RequestComplete();
         }
         return;
@@ skipping 378 matching lines @@
 
 TEST_F(BlobURLRequestJobTest, TestExtraHeaders) {
   RunTestOnIOThread(&BlobURLRequestJobTest::TestExtraHeaders);
 }
 
 }  // namespace webkit_blob
 
 // BlobURLRequestJobTest is expected to always live longer than the
 // runnable methods.  This lets us call NewRunnableMethod on its instances.
 DISABLE_RUNNABLE_METHOD_REFCOUNT(webkit_blob::BlobURLRequestJobTest);