Changes to have chrome building with net.dll

Changes to have chrome building with net.dll

BUG=76997
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87873

[wtc, 2011-06-03 18:24:39]

LGTM.

http://codereview.chromium.org/7056049/diff/1/chrome/browser/net/cookie_polic...
File chrome/browser/net/cookie_policy_browsertest.cc (left):

http://codereview.chromium.org/7056049/diff/1/chrome/browser/net/cookie_polic...
chrome/browser/net/cookie_policy_browsertest.cc:15: #include
"net/url_request/url_request_context.cc"
Wow, no kidding!

This is worth separating into its own CL.

http://codereview.chromium.org/7056049/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

http://codereview.chromium.org/7056049/diff/1/chrome/chrome.gyp#newcode426
chrome/chrome.gyp:426: '../net/net.gyp:net',
Nit: does net.gyp:net need to be before net.gyp:http_server,
or can we list them in alphabetical order?

http://codereview.chromium.org/7056049/diff/1/chrome_frame/chrome_frame.gyp
File chrome_frame/chrome_frame.gyp (right):

http://codereview.chromium.org/7056049/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:678: '../net/net.gyp:net',
Nit: list in alphabetical order?

http://codereview.chromium.org/7056049/diff/1/webkit/blob/blob_url_request_jo...
File webkit/blob/blob_url_request_job_unittest.cc (right):

http://codereview.chromium.org/7056049/diff/1/webkit/blob/blob_url_request_jo...
webkit/blob/blob_url_request_job_unittest.cc:74: if (request->job()->is_done())
{
I believe we can replace this with
    if (!request->is_pending()) {

See the following code in url_request_job.cc:

void URLRequestJob::NotifyDone(const URLRequestStatus &status) {
  DCHECK(!done_) << "Job sending done notification twice";
  if (done_)
    return;
  done_ = true;
  ^^^^^^^^^^^^^

  // Unless there was an error, we should have at least tried to handle
  // the response before getting here.
  DCHECK(has_handled_response_ || !status.is_success());

  // As with NotifyReadComplete, we need to take care to notice if we were
  // destroyed during a delegate callback.
  if (request_) {
    request_->set_is_pending(false);
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...

[rvargas (doing something else), 2011-06-03 18:47:42]

Thanks

http://codereview.chromium.org/7056049/diff/1/chrome/browser/net/cookie_polic...
File chrome/browser/net/cookie_policy_browsertest.cc (left):

http://codereview.chromium.org/7056049/diff/1/chrome/browser/net/cookie_polic...
chrome/browser/net/cookie_policy_browsertest.cc:15: #include
"net/url_request/url_request_context.cc"
On 2011/06/03 18:24:40, wtc wrote:
> Wow, no kidding!
> 
> This is worth separating into its own CL.

Done.

http://codereview.chromium.org/7056049/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

http://codereview.chromium.org/7056049/diff/1/chrome/chrome.gyp#newcode426
chrome/chrome.gyp:426: '../net/net.gyp:net',
On 2011/06/03 18:24:40, wtc wrote:
> Nit: does net.gyp:net need to be before net.gyp:http_server,
> or can we list them in alphabetical order?

Done.

http://codereview.chromium.org/7056049/diff/1/chrome_frame/chrome_frame.gyp
File chrome_frame/chrome_frame.gyp (right):

http://codereview.chromium.org/7056049/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:678: '../net/net.gyp:net',
On 2011/06/03 18:24:40, wtc wrote:
> Nit: list in alphabetical order?

Done.

http://codereview.chromium.org/7056049/diff/1/webkit/blob/blob_url_request_jo...
File webkit/blob/blob_url_request_job_unittest.cc (right):

http://codereview.chromium.org/7056049/diff/1/webkit/blob/blob_url_request_jo...
webkit/blob/blob_url_request_job_unittest.cc:74: if (request->job()->is_done())
{
I added your comment to the bug report.