Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7055018: Print Preview: Delaying page range validation (Closed)

Created:
9 years, 7 months ago by dpapad
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Print Preview: Delaying page range validation Also 1) adding border between printing controls and preview area. 2) showing an error message when initiator tab is closed regardless of the state of the preview area. BUG=83251, 83429, 83410 TEST=See bug description. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86196

Patch Set 1 #

Patch Set 2 : Adding border between controls and preview area #

Patch Set 3 : Changing behavior when initiator tab is closed #

Total comments: 2

Patch Set 4 : Updating comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M chrome/browser/resources/print_preview.css View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview.js View 1 2 3 5 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dpapad
9 years, 7 months ago (2011-05-20 22:38:09 UTC) #1
dpapad
Added one more bug fix in this CL.
9 years, 7 months ago (2011-05-20 22:46:05 UTC) #2
Lei Zhang
http://codereview.chromium.org/7055018/diff/4001/chrome/browser/resources/print_preview.js File chrome/browser/resources/print_preview.js (right): http://codereview.chromium.org/7055018/diff/4001/chrome/browser/resources/print_preview.js#newcode538 chrome/browser/resources/print_preview.js:538: function pageRangesFieldChanged() { Can you update the comment?
9 years, 7 months ago (2011-05-20 23:16:22 UTC) #3
dpapad
http://codereview.chromium.org/7055018/diff/4001/chrome/browser/resources/print_preview.js File chrome/browser/resources/print_preview.js (right): http://codereview.chromium.org/7055018/diff/4001/chrome/browser/resources/print_preview.js#newcode538 chrome/browser/resources/print_preview.js:538: function pageRangesFieldChanged() { On 2011/05/20 23:16:23, Lei Zhang wrote: ...
9 years, 7 months ago (2011-05-20 23:26:24 UTC) #4
Lei Zhang
LGTM
9 years, 7 months ago (2011-05-20 23:31:39 UTC) #5
commit-bot: I haz the power
9 years, 7 months ago (2011-05-21 02:00:50 UTC) #6 
Change committed as 86196

Powered by Google App Engine
This is Rietveld 408576698