Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2490)

Unified Diff: chrome/browser/resources/print_preview.js

Issue 7055018: Print Preview: Delaying page range validation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updating comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview.js
diff --git a/chrome/browser/resources/print_preview.js b/chrome/browser/resources/print_preview.js
index f9172533f9b143965fe210d90ac20fe8e6ecdae3..b9b935f8406d619802c192c6899e5381c9d9f776 100644
--- a/chrome/browser/resources/print_preview.js
+++ b/chrome/browser/resources/print_preview.js
@@ -64,7 +64,7 @@ function onLoad() {
onPageSelectionMayHaveChanged();
});
$('individual-pages').addEventListener('focus', addTimerToPageRangeField);
- $('individual-pages').addEventListener('input', pageRangesFieldChanged);
+ $('individual-pages').addEventListener('input', resetPageRangeFieldTimer);
$('two-sided').addEventListener('click', handleTwoSidedClick)
$('landscape').addEventListener('click', onLayoutModeToggle);
$('portrait').addEventListener('click', onLayoutModeToggle);
@@ -101,15 +101,8 @@ function showSystemDialog() {
* @param {string} initiatorTabURL The URL of the initiator tab.
*/
function onInitiatorTabClosed(initiatorTabURL) {
- if (isPreviewStillLoading)
- displayErrorMessage(localStrings.getStringF('initiatorTabClosed',
- initiatorTabURL));
-
- var controlIDs = ['landscape', 'portrait', 'all-pages', 'print-pages',
- 'individual-pages', 'printer-list'];
- var controlCount = controlIDs.length;
- for (var i = 0; i < controlCount; i++)
- $(controlIDs[i]).disabled = true;
+ displayErrorMessage(localStrings.getStringF('initiatorTabClosed',
+ initiatorTabURL));
}
/**
@@ -537,8 +530,8 @@ function copiesFieldChanged() {
}
/**
- * Executes whenever an input event occurs on the 'individual-pages'
- * field. It takes care of
+ * Executes whenever a blur event occurs on the 'individual-pages'
+ * field or when the timer expires. It takes care of
* 1) showing/hiding warnings/suggestions
* 2) updating print button/summary
*/
@@ -661,7 +654,6 @@ function handleTwoSidedClick() {
* clicked.
*/
function handleIndividualPagesCheckbox() {
- onPageSelectionMayHaveChanged();
$('individual-pages').focus();
}
@@ -860,6 +852,8 @@ function resetPageRangeFieldTimer() {
* 2) The newly selected pages differ from the previously selected.
*/
function onPageSelectionMayHaveChanged() {
+ if ($('print-pages').checked)
+ pageRangesFieldChanged();
var validityLevel = getSelectedPagesValidityLevel();
var currentlySelectedPages = getSelectedPagesSet();
« no previous file with comments | « chrome/browser/resources/print_preview.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698