Issue 7054031: Mac: Use cross-platform menu model for profile button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7054031: Mac: Use cross-platform menu model for profile button. (Closed)

Created:
9 years, 7 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan, sail, Ben Goodger (Google), sky

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Use cross-platform menu model for profile button. Also move the SimpleMenuModel::Delegate back into ProfileButtonMenu BUG=83169 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86224

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -61 lines)			Patch
M	chrome/browser/ui/cocoa/profile_menu_button.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/profile_menu_button.mm	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/profile_menu_model.h	View	1 chunk	+13 lines, -5 lines	1 comment	Download
M	chrome/browser/ui/profile_menu_model.cc	View	1 chunk	+29 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/profile_menu_button.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	chrome/browser/ui/views/profile_menu_button.cc	View	3 chunks	+1 line, -27 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

On 2011/05/21 05:18:03, Nico wrote: LGTM if you promise not to move the delegate again. ...

9 years, 7 months ago (2011-05-21 11:49:57 UTC) #2

sky

9 years, 7 months ago (2011-05-23 14:44:38 UTC) #5

LGTM

http://codereview.chromium.org/7054031/diff/1/chrome/browser/ui/profile_menu_...
File chrome/browser/ui/profile_menu_model.h (right):

http://codereview.chromium.org/7054031/diff/1/chrome/browser/ui/profile_menu_...
chrome/browser/ui/profile_menu_model.h:19: explicit ProfileMenuModel();
nit: no explicit

Expand Messages | Collapse Messages