Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7146)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 7054031: Mac: Use cross-platform menu model for profile button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
index 2c8fccc088d407b1c164191509dfdfe6eca64409..9a0c310870fbcac8414336faffbe60704857fc02 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
@@ -175,7 +175,6 @@ private:
- (void)updateCommonTitlePrefix;
- (BOOL)shouldShowProfileMenuButton;
- (void)updateProfileMenuButton;
-- (void)createNewProfile:(id)sender;
@end
// A simple view class that prevents the Window Server from dragging the area
@@ -2177,23 +2176,6 @@ class NotificationBridge : public NotificationObserver {
[profileMenuButton_ setProfileDisplayName:
[NSString stringWithUTF8String:profileName.c_str()]];
[profileMenuButton_ setHidden:NO];
-
- NSMenu* menu = [profileMenuButton_ menu];
- while ([menu numberOfItems] > 0) {
- [menu removeItemAtIndex:0];
- }
-
- NSString* menuTitle =
- l10n_util::GetNSStringWithFixup(IDS_PROFILES_CREATE_NEW_PROFILE_OPTION);
- NSMenuItem* menuItem = [menu addItemWithTitle:menuTitle
- action:@selector(createNewProfile:)
- keyEquivalent:@""];
- [menuItem setState:NSOffState];
- [menuItem setTarget:self];
-}
-
-- (void)createNewProfile:(id)sender {
- ProfileManager::CreateMultiProfileAsync();
}
@end

Powered by Google App Engine
This is Rietveld 408576698