Fix a number of tests that incorrectly used assertUnreachable.

Fix a number of tests that incorrectly used assertUnreachable.

Our testing infrastructure uses exceptions to indicate
errors. assertUnreachable therefore throws an exception to indicate
that it was reached. Therefore, it cannot be used to check that an
exception was thrown using the pattern:

try {
  shouldThrow();
  assertUnreachable();
} catch(e) {
}

Such a test will always pass because assertUnreachable will throw an
exception if shouldThrow does not.

R=ricow@chromium.org

[Rico, 2011-05-31 07:59:16]

LGTM
As discussed online this is only a problem if we don't explicitly test the type
of the error that we catch, but I think it is a good idea to remove this
altogether. Maybe we should remove this from mjsunit.js so that people do not
use this wrongly in the future?

http://codereview.chromium.org/7053035/diff/1/test/mjsunit/regress/regress-24...
File test/mjsunit/regress/regress-244.js (right):

http://codereview.chromium.org/7053035/diff/1/test/mjsunit/regress/regress-24...
test/mjsunit/regress/regress-244.js:57: var threw = false;
threw is not used

[Mads Ager (chromium), 2011-05-31 08:05:51]

http://codereview.chromium.org/7053035/diff/1/test/mjsunit/regress/regress-24...
File test/mjsunit/regress/regress-244.js (right):

http://codereview.chromium.org/7053035/diff/1/test/mjsunit/regress/regress-24...
test/mjsunit/regress/regress-244.js:57: var threw = false;
On 2011/05/31 07:59:16, Rico wrote:
> threw is not used

Removed.