Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: test/mjsunit/property-load-across-eval.js

Issue 7053035: Fix a number of tests that incorrectly used assertUnreachable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/object-seal.js ('k') | test/mjsunit/regress/regress-1119.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/property-load-across-eval.js
diff --git a/test/mjsunit/property-load-across-eval.js b/test/mjsunit/property-load-across-eval.js
index 5419cc7f3b905d235be703e06b90ef8e9f134b62..98b621e7922588acf0e5a73af91dc487a0ac2c6c 100644
--- a/test/mjsunit/property-load-across-eval.js
+++ b/test/mjsunit/property-load-across-eval.js
@@ -45,19 +45,21 @@ function testNoShadowing() {
assertEquals(2, y);
assertEquals('global', global_function());
assertEquals('local', local_function());
+ var exception = false;
try {
const_uninitialized();
- assertUnreachable();
} catch(e) {
- // Ignore.
+ exception = true;
}
+ assertTrue(exception);
assertEquals('const_global', const_initialized());
+ exception = false;
try {
local_const_uninitialized();
- assertUnreachable();
} catch(e) {
- // Ignore.
+ exception = true;
}
+ assertTrue(exception);
assertEquals('const_local', local_const_initialized());
function g() {
assertEquals(1, x);
@@ -65,19 +67,21 @@ function testNoShadowing() {
assertEquals(2, y);
assertEquals('global', global_function());
assertEquals('local', local_function());
+ var exception = false;
try {
const_uninitialized();
- assertUnreachable();
} catch(e) {
- // Ignore.
+ exception = true;
}
+ assertTrue(exception);
assertEquals('const_global', const_initialized());
+ exception = false;
try {
local_const_uninitialized();
- assertUnreachable();
} catch(e) {
- // Ignore.
+ exception = true;
}
+ assertTrue(exception);
assertEquals('const_local', local_const_initialized());
}
g();
« no previous file with comments | « test/mjsunit/object-seal.js ('k') | test/mjsunit/regress/regress-1119.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698