chrome/browser/ui/gtk/browser_toolbar_gtk.cc - Issue 7049004: Normalize chrome://foo/ trailing slashes, ChromeURLHostEquals comparison, RIP dead consts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_toolbar_gtk.cc

Issue 7049004: Normalize chrome://foo/ trailing slashes, ChromeURLHostEquals comparison, RIP dead consts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove stdlib.h include. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/browser_toolbar_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

index 863fe3d4c9643128626a139305852d1e9be4c526..746c4963047282aa467cdca681d47a968ef1e148 100644

--- a/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

@@ -606,7 +606,7 @@ void BrowserToolbarGtk::OnDragDataReceived(GtkWidget* widget,

if (!url.is_valid())

return;

- bool url_is_newtab = url.spec() == chrome::kChromeUINewTabURL;

+ bool url_is_newtab = url == GURL(chrome::kChromeUINewTabURL);

Evan Stade 2011/05/20 05:18:43 sorry, I guess I was unclear during our chat. I co

msw 2011/05/22 01:12:12 Done.

home_page_is_new_tab_page_.SetValue(url_is_newtab);

if (!url_is_newtab)

home_page_.SetValue(url.spec());

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/BidiCheckerWebUITest.cc » ('j') | no next file with comments »