Normalize chrome://foo/ trailing slashes, ChromeURLHostEquals comparison, RIP dead consts.

chrome/browser/ui/gtk/browser_toolbar_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/browser_toolbar_gtk.h"
 
 #include <X11/XF86keysym.h>
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 
@@ skipping 588 matching lines @@
     GtkSelectionData* data, guint info, guint time) {
   if (info != ui::TEXT_PLAIN) {
     NOTIMPLEMENTED() << "Only support plain text drops for now, sorry!";
     return;
   }
 
   GURL url(reinterpret_cast<char*>(data->data));
   if (!url.is_valid())
     return;
 
-  bool url_is_newtab = url.spec() == chrome::kChromeUINewTabURL;
+  bool url_is_newtab = url == GURL(chrome::kChromeUINewTabURL);

[Evan Stade, 2011/05/20 05:18:43]

sorry, I guess I was unclear during our chat. I count this as one of the places
you are "touching", hence it should be changed to the other matching style.

[msw, 2011/05/22 01:12:12]

Done.

   home_page_is_new_tab_page_.SetValue(url_is_newtab);
   if (!url_is_newtab)
     home_page_.SetValue(url.spec());
 }
 
 void BrowserToolbarGtk::NotifyPrefChanged(const std::string* pref) {
   if (!pref || *pref == prefs::kShowHomeButton) {
     if (show_home_button_.GetValue() && !ShouldOnlyShowLocation()) {
       gtk_widget_show(home_->widget());
     } else {
@@ skipping 29 matching lines @@
   int x_offset = base::i18n::IsRTL() ? 0 :
       sender->allocation.width - badge->width();
   int y_offset = 0;
   canvas.DrawBitmapInt(
       *badge,
       sender->allocation.x + x_offset,
       sender->allocation.y + y_offset);
 
   return FALSE;
 }