Issue 7049002: Move the check to detect first login before adding the User to the UserManager

Issue 7049002: Move the check to detect first login before adding the User to the UserManager (Closed)

Created:
9 years, 7 months ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow), Yusuke Sato, commit-bot: I haz the power, zel

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move the check to detect first login before adding the User to the UserManager BUG=chromium-os:15526 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86275

Patch Set 4 : Code Review Fix #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/chromeos/login/login_utils.cc	View	1 2 3	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

nit: BUG field should have format chromium-os:15526 this way it will be a link.

9 years, 7 months ago (2011-05-20 09:27:15 UTC) #2

Nikita (slow)

http://codereview.chromium.org/7049002/diff/4001/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): http://codereview.chromium.org/7049002/diff/4001/chrome/browser/chromeos/login/login_utils.cc#newcode327 chrome/browser/chromeos/login/login_utils.cc:327: if (first_login_) { Turns out that UserManager has bool ...

9 years, 7 months ago (2011-05-20 09:33:46 UTC) #3

Zachary Kuznia

9 years, 7 months ago (2011-05-23 08:06:35 UTC) #4

zel

9 years, 7 months ago (2011-05-27 01:32:56 UTC) #7

On 2011/05/23 10:07:45, commit-bot wrote:
> Change committed as 86275

approved merge into 742

Expand Messages | Collapse Messages