Move the check to detect first login before adding the User to the UserManager

chrome/browser/chromeos/login/login_utils.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/login_utils.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
@@ skipping 226 matching lines @@
   // will process the notification that the UserManager sends out.
   ProfileManager::CreateDefaultProfileAsync(this);
 }
 
 void LoginUtilsImpl::OnProfileCreated(Profile* profile) {
   CHECK(profile);
 
   BootTimesLoader* btl = BootTimesLoader::Get();
   btl->AddLoginTimeMarker("UserProfileGotten", false);
 
-  bool first_login = !UserManager::Get()->IsKnownUser(username_);
   // Change the proxy configuration service of the default request context to
   // use the preference configuration from the logged-in profile. This ensures
   // that requests done through the default context use the proxy configuration
   // provided by configuration policy.
   //
   // Note: Many of the clients of the default request context should probably be
   // fixed to use the request context of the profile they are associated with.
   // This includes preconnect, autofill, metrics service to only name a few;
   // see http://code.google.com/p/chromium/issues/detail?id=64339 for details.
   //
@@ skipping 55 matching lines @@
         cryptohome->TpmClearStoredPassword();
       } else {
         cryptohome->TpmCanAttemptOwnership();
       }
     }
   }
   btl->AddLoginTimeMarker("TPMOwned", false);
 
   RespectLocalePreference(profile);
 
-  if (first_login) {
+  if (UserManager::Get()->current_user_is_new()) {
     SetFirstLoginPrefs(profile->GetPrefs());
   }
 
   // Enable/disable plugins based on user preferences.
   PluginUpdater::GetInstance()->SetProfile(profile);
   btl->AddLoginTimeMarker("PluginsStateUpdated", false);
 
   // We suck. This is a hack since we do not have the enterprise feature
   // done yet to pull down policies from the domain admin. We'll take this
   // out when we get that done properly.
@@ skipping 260 matching lines @@
   // Mark login host for deletion after browser starts.  This
   // guarantees that the message loop will be referenced by the
   // browser before it is dereferenced by the login host.
   if (login_host) {
     login_host->OnSessionStart();
     login_host = NULL;
   }
 }
 
 }  // namespace chromeos