Issue 7046080: When replacing an infobar, maintain the old infobar's position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046080: When replacing an infobar, maintain the old infobar's position. (Closed)

Created:
9 years, 6 months ago by Peter Kasting

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When replacing an infobar, maintain the old infobar's position. BUG=none TEST=Visit a page in another language (to get the translate infobar), then kill Flash to also get a crashed plugin infobar. Tell the page to translate and ensure the infobars don't switch places. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88615

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -27 lines)			Patch
M	chrome/browser/tab_contents/infobar_container.h	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/tab_contents/infobar_container.cc	View	5 chunks	+15 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_container_view.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_container_view.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages