When replacing an infobar, maintain the old infobar's position.

chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "chrome/browser/autocomplete_history_manager.h"
 #include "chrome/browser/autofill/autofill_manager.h"
@@ skipping 497 matching lines @@
   DCHECK(it != infobar_delegates_.end());
 
   // Notify the container about the change of plans.
   typedef std::pair<InfoBarDelegate*, InfoBarDelegate*> ReplaceDetails;
   ReplaceDetails replace_details(old_delegate, new_delegate);
   NotificationService::current()->Notify(
       NotificationType::TAB_CONTENTS_INFOBAR_REPLACED,
       Source<TabContentsWrapper>(this),
       Details<ReplaceDetails>(&replace_details));
 
-  // Remove the old one.
-  infobar_delegates_.erase(it);
-
-  // Add the new one.
   DCHECK(find(infobar_delegates_.begin(),
               infobar_delegates_.end(), new_delegate) ==
          infobar_delegates_.end());
-  infobar_delegates_.push_back(new_delegate);
+  infobar_delegates_.erase(infobar_delegates_.insert(it, new_delegate) + 1);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Internal helpers
 
 void TabContentsWrapper::OnJSOutOfMemory() {
   AddInfoBar(new SimpleAlertInfoBarDelegate(tab_contents(),
       NULL, l10n_util::GetStringUTF16(IDS_JS_OUT_OF_MEMORY_PROMPT), true));
 }
 
@@ skipping 54 matching lines @@
 void TabContentsWrapper::UpdateWebPreferences() {
   RenderViewHostDelegate* rvhd = tab_contents();
   Send(new ViewMsg_UpdateWebPreferences(routing_id(), rvhd->GetWebkitPrefs()));
 }
 
 void TabContentsWrapper::UpdateRendererPreferences() {
   renderer_preferences_util::UpdateFromSystemSettings(
       tab_contents()->GetMutableRendererPrefs(), profile());
   render_view_host()->SyncRendererPrefs();
 }