Issue 7046077: Revert 88510 - Escaping file names correctly. Also fixed a crush in chromeos debug build while sa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046077: Revert 88510 - Escaping file names correctly. Also fixed a crush in chromeos debug build while sa... (Closed)

Created:
9 years, 6 months ago by ericu

Modified:
9 years, 6 months ago

Reviewers:
SeRya

CC:
chromium-reviews, cbentzel+watch_chromium.org, idana, Raghu Simha, Erik does not do reviews, achuith+watch_chromium.org, ncarter (slow), Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr., davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 88510 - Escaping file names correctly. Also fixed a crush in chromeos debug build while saving a web page. This change broke the official CrOS builder. I'll forward the error separately. BUG=chromium-os:13130 TEST=Save a file with special characters like '#', '&', '"'. Review URL: http://codereview.chromium.org/7057053 TBR=serya@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88553

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -79 lines)			Patch
MM	chrome/browser/chromeos/status/network_menu.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/browser/extensions/file_manager_util.cc	View	6 chunks	+6 lines, -7 lines	0 comments	Download
MM	chrome/browser/resources/file_manager/js/file_manager.js	View	5 chunks	+4 lines, -32 lines	0 comments	Download
MM	chrome/browser/sync/engine/net/url_translator.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
MM	chrome/browser/translate/translate_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/net/gaia/gaia_auth_fetcher.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/common/net/gaia/gaia_authenticator.cc	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/common/net/gaia/gaia_oauth_client.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	net/base/escape.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	net/base/escape.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	net/base/escape_unittest.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages