Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/common/net/gaia/gaia_authenticator.cc

Issue 7046077: Revert 88510 - Escaping file names correctly. Also fixed a crush in chromeos debug build while sa... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/gaia/gaia_auth_fetcher.cc ('k') | chrome/common/net/gaia/gaia_oauth_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/gaia/gaia_authenticator.cc
===================================================================
--- chrome/common/net/gaia/gaia_authenticator.cc (revision 88552)
+++ chrome/common/net/gaia/gaia_authenticator.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -158,15 +158,13 @@
GURL gaia_auth_url(gaia_url_);
string post_body;
- post_body += "Email=" + EscapeUrlEncodedData(params.email, true);
- post_body += "&Passwd=" + EscapeUrlEncodedData(params.password, true);
- post_body += "&source=" + EscapeUrlEncodedData(user_agent_, true);
+ post_body += "Email=" + EscapeUrlEncodedData(params.email);
+ post_body += "&Passwd=" + EscapeUrlEncodedData(params.password);
+ post_body += "&source=" + EscapeUrlEncodedData(user_agent_);
post_body += "&service=" + service_id_;
if (!params.captcha_token.empty() && !params.captcha_value.empty()) {
- post_body += "&logintoken=" +
- EscapeUrlEncodedData(params.captcha_token, true);
- post_body += "&logincaptcha=" +
- EscapeUrlEncodedData(params.captcha_value, true);
+ post_body += "&logintoken=" + EscapeUrlEncodedData(params.captcha_token);
+ post_body += "&logincaptcha=" + EscapeUrlEncodedData(params.captcha_value);
}
post_body += "&PersistentCookie=true";
// We set it to GOOGLE (and not HOSTED or HOSTED_OR_GOOGLE) because we only
@@ -217,7 +215,7 @@
string post_body;
post_body += "LSID=";
- post_body += EscapeUrlEncodedData(results->lsid, true);
+ post_body += EscapeUrlEncodedData(results->lsid);
unsigned long server_response_code;
string message_text;
@@ -267,7 +265,7 @@
string post_body;
post_body += "LSID=";
- post_body += EscapeUrlEncodedData(results->lsid, true);
+ post_body += EscapeUrlEncodedData(results->lsid);
post_body += "&service=" + service_id;
post_body += "&Session=true";
« no previous file with comments | « chrome/common/net/gaia/gaia_auth_fetcher.cc ('k') | chrome/common/net/gaia/gaia_oauth_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698