Issue 7046063: Fix the user-action stats for the safe browsing interstitial so that it works in release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046063: Fix the user-action stats for the safe browsing interstitial so that it works in release builds. (Closed)

Created:
9 years, 6 months ago by Brian Ryner

Modified:
9 years, 6 months ago

Reviewers:
noelutz, mattm

CC:
chromium-reviews, chrome-anti-phishing_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix the user-action stats for the safe browsing interstitial so that it works in release builds. BUG=79947 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88554

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/safe_browsing/safe_browsing_blocking_page.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

noelutz

Yeah, nice catch. Can't wait to see the number ;). noé. On 2011/06/09 00:37:17, mattm ...

9 years, 6 months ago (2011-06-09 15:24:24 UTC) #3

noelutz

9 years, 6 months ago (2011-06-09 15:24:33 UTC) #4

LGTM

On 2011/06/09 15:24:24, noelutz wrote:
> Yeah, nice catch.  Can't wait to see the number ;).
> noé.
> 
> On 2011/06/09 00:37:17, mattm wrote:
> > Gah! Good catch.
> > 
> > LGTM

Expand Messages | Collapse Messages