chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 7046063: Fix the user-action stats for the safe browsing interstitial so that it works in release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 7046063: Fix the user-action stats for the safe browsing interstitial so that it works in release builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index 386415283fc9392055744928ad3e0e87edec4cbf..b0c4999176dfe1907e0af8d81e1a98a4acc57a4c 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -589,7 +589,8 @@ void SafeBrowsingBlockingPage::RecordUserAction(BlockingPageEvent event) {

PopulateMultipleThreatStringDictionary(&strings);

string16 title;

- DCHECK(strings.GetString("title", &title));

+ bool success = strings.GetString("title", &title);

+ DCHECK(success);

std::string action = "SBInterstitial";

if (title ==

« no previous file with comments | « no previous file | no next file » | no next file with comments »