Restore favicons to chrome://extensions and chrome://bookmarks page (among probably other things).

chrome/browser/ui/webui/chrome_web_ui_factory.cc

Index: chrome/browser/ui/webui/chrome_web_ui_factory.cc
===================================================================
--- chrome/browser/ui/webui/chrome_web_ui_factory.cc	(revision 88118)
+++ chrome/browser/ui/webui/chrome_web_ui_factory.cc	(working copy)
@@ -9,6 +9,7 @@
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
 #include "chrome/browser/extensions/extensions_ui.h"
+#include "chrome/browser/history/history_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/bookmarks_ui.h"
 #include "chrome/browser/ui/webui/bug_report_ui.h"
@@ -286,6 +287,7 @@
         GetFaviconResourceBytes(page_url));
     favicon.known_icon = favicon.image_data.get() != NULL &&
                              favicon.image_data->size() > 0;
+    favicon.icon_type = history::FAVICON;

[michaelbai, 2011/06/09 15:49:44]

Would the issue be fixed by only adding this line?

[Finnur, 2011/06/09 16:01:57]

Yes. The other two were found by searching. I guess I didn't look closely
enough.

I have uploaded a new CL.

     request->ForwardResultAsync(
         FaviconService::FaviconDataCallback::TupleType(request->handle(),
                                                        favicon));