chrome/browser/history/history_backend.cc - Issue 7046049: Restore favicons to chrome://extensions and chrome://bookmarks page (among probably other things).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.cc

Issue 7046049: Restore favicons to chrome://extensions and chrome://bookmarks page (among probably other things). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/history_backend.cc

===================================================================

--- chrome/browser/history/history_backend.cc (revision 88118)

+++ chrome/browser/history/history_backend.cc (working copy)

@@ -1716,6 +1716,7 @@

favicon.expired = (Time::Now() - last_updated) >

TimeDelta::FromDays(kFaviconRefetchDays);

favicon.image_data = data;

+ favicon.icon_type = history::FAVICON;

michaelbai 2011/06/09 15:49:44 The favicon.icon_type should be returned from line

}

if (page_url)

@@ -1753,6 +1754,7 @@

TimeDelta::FromDays(kFaviconRefetchDays);

favicon.icon_type = icon_mappings.front().icon_type;

favicon.image_data = data;

+ favicon.icon_type = history::FAVICON;

michaelbai 2011/06/09 15:49:44 The favicon.icon_type should be set in line 1755.

Finnur 2011/06/09 16:01:57 Ah, yes. You are right. I'll remove this file enti

}

UMA_HISTOGRAM_TIMES("History.GetFavIconForURL", // historical name

« no previous file with comments | « no previous file | chrome/browser/ui/webui/chrome_web_ui_factory.cc » ('j') | chrome/browser/ui/webui/chrome_web_ui_factory.cc » ('J')