Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 7042029: Code to migrate a single directory from the old sandbox to the new. (Closed)

Created:
9 years, 7 months ago by ericu
Modified:
9 years, 7 months ago
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, Paweł Hajdan Jr., Dai Mikurube (NOT FULLTIME)
Visibility:
Public.

Description

Code to migrate a single directory from the old sandbox to the new. Also cleans up the new directory path format just a bit, and makes the database store relative paths instead of absolute ones, so that if the user moves her profile path, things don't break. BUG=none TEST=unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86145

Patch Set 1 #

Patch Set 2 : Fully tested; shortened type subdirs, lengthened origin dir. #

Patch Set 3 : Added TODO about directory mtime updates. #

Total comments: 6

Patch Set 4 : Code review fixes. #

Patch Set 5 : Windows build fixes. #

Patch Set 6 : Attempted windows fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -43 lines) Patch
M webkit/fileapi/file_system_directory_database.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_directory_database.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_origin_database.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M webkit/fileapi/obfuscated_file_system_file_util.h View 1 2 3 3 chunks +37 lines, -7 lines 0 comments Download
M webkit/fileapi/obfuscated_file_system_file_util.cc View 1 2 3 17 chunks +173 lines, -35 lines 0 comments Download
M webkit/fileapi/obfuscated_file_system_file_util_unittest.cc View 1 2 3 4 5 3 chunks +98 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ericu
9 years, 7 months ago (2011-05-19 19:02:49 UTC) #1
michaeln
lgtm http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_file_system_file_util.cc File webkit/fileapi/obfuscated_file_system_file_util.cc (right): http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_file_system_file_util.cc#newcode806 webkit/fileapi/obfuscated_file_system_file_util.cc:806: case kFileSystemTypeTemporary: nit: i think our style-guide wants ...
9 years, 7 months ago (2011-05-20 02:15:16 UTC) #2
ericu
http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_file_system_file_util.cc File webkit/fileapi/obfuscated_file_system_file_util.cc (right): http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_file_system_file_util.cc#newcode806 webkit/fileapi/obfuscated_file_system_file_util.cc:806: case kFileSystemTypeTemporary: On 2011/05/20 02:15:16, michaeln wrote: > nit: ...
9 years, 7 months ago (2011-05-20 02:23:25 UTC) #3
commit-bot: I haz the power
9 years, 7 months ago (2011-05-20 21:02:36 UTC) #4
Change committed as 86145

Powered by Google App Engine
This is Rietveld 408576698