Code to migrate a single directory from the old sandbox to the new.

Code to migrate a single directory from the old sandbox to the new.

Also cleans up the new directory path format just a bit, and makes the database store relative paths instead of absolute ones, so that if the user moves her profile path, things don't break.

BUG=none
TEST=unit test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86145

[michaeln, 2011-05-20 02:15:16]

lgtm

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
File webkit/fileapi/obfuscated_file_system_file_util.cc (right):

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.cc:806: case
kFileSystemTypeTemporary:
nit: i think our style-guide wants the case to be indented?

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
File webkit/fileapi/obfuscated_file_system_file_util.h (right):

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.h:164: // which to COPY
data--otherwise leave it empty.  On success, data_path will
please fixup this comment

* make it clear that file_info.data_path is not used as the input

* the comment about how data_path will contain a full path is now stale

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.h:188: const GURL& origin,
FileSystemType type, const FilePath& virtual_path);
virtual_path s/b data_path in the arg list

[ericu, 2011-05-20 02:23:25]

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
File webkit/fileapi/obfuscated_file_system_file_util.cc (right):

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.cc:806: case
kFileSystemTypeTemporary:
On 2011/05/20 02:15:16, michaeln wrote:
> nit: i think our style-guide wants the case to be indented?

Done.

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
File webkit/fileapi/obfuscated_file_system_file_util.h (right):

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.h:164: // which to COPY
data--otherwise leave it empty.  On success, data_path will
On 2011/05/20 02:15:16, michaeln wrote:
> please fixup this comment
> 
> * make it clear that file_info.data_path is not used as the input
> 
> * the comment about how data_path will contain a full path is now stale

Done, thanks for catching that.

http://codereview.chromium.org/7042029/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.h:188: const GURL& origin,
FileSystemType type, const FilePath& virtual_path);
On 2011/05/20 02:15:16, michaeln wrote:
> virtual_path s/b data_path in the arg list

Done.

[commit-bot: I haz the power, 2011-05-20 21:02:36]

Change committed as 86145