Check for integer overflow when validating API function arguments.

chrome/browser/extensions/window_open_apitest.cc

Index: chrome/browser/extensions/window_open_apitest.cc
diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc
index edd13b8c14f47924b619129367b2377ad0d22bb0..3cd160844d67efec784f5cc2832cf9081cb395e4 100644
--- a/chrome/browser/extensions/window_open_apitest.cc
+++ b/chrome/browser/extensions/window_open_apitest.cc
@@ -100,6 +100,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenFocus) {
 }
 #endif
 
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowArgumentsOverflow) {
+  ASSERT_TRUE(RunExtensionTest("window_open/argument_overflow")) << message_;

[asargent_no_longer_on_chrome, 2011/05/19 18:36:48]

nit: is this test at all related to the other tests in the window_open
directory? If not, maybe move the argument_overflow directory to be at the same
level as window_open (eg in chrome/test/data/extensions/api_test/) and move this
block of code into something like
chrome/browser/extensions/validation_apitest.cc.

[Ben Olmstead, 2011/05/19 20:34:18]

It's debatable.  The bug explicitly calls out windows.create(), but almost
certainly affects any API that takes integer arguments.

I found out about chrome/test/data/extensions/json_schema_test.js, so I will add
a more general test there.

+}
+
 class WindowOpenPanelTest : public ExtensionApiTest {
   virtual void SetUpCommandLine(CommandLine* command_line) {
     ExtensionApiTest::SetUpCommandLine(command_line);