Check for integer overflow when validating API function arguments.

chrome/browser/extensions/window_open_apitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/ui_test_utils.h"
@@ skipping 82 matching lines @@
   WaitForTabsAndPopups(browser(), 3, 1);
 }
 
 #if defined(OS_MACOSX) || defined(OS_WIN)
 // Focus test fails if there is no window manager on Linux.
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenFocus) {
   ASSERT_TRUE(RunExtensionTest("window_open/focus")) << message_;
 }
 #endif
 
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowArgumentsOverflow) {
+  ASSERT_TRUE(RunExtensionTest("window_open/argument_overflow")) << message_;

[asargent_no_longer_on_chrome, 2011/05/19 18:36:48]

nit: is this test at all related to the other tests in the window_open
directory? If not, maybe move the argument_overflow directory to be at the same
level as window_open (eg in chrome/test/data/extensions/api_test/) and move this
block of code into something like
chrome/browser/extensions/validation_apitest.cc.

[Ben Olmstead, 2011/05/19 20:34:18]

It's debatable.  The bug explicitly calls out windows.create(), but almost
certainly affects any API that takes integer arguments.

I found out about chrome/test/data/extensions/json_schema_test.js, so I will add
a more general test there.

+}
+
 class WindowOpenPanelTest : public ExtensionApiTest {
   virtual void SetUpCommandLine(CommandLine* command_line) {
     ExtensionApiTest::SetUpCommandLine(command_line);
     command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);
     command_line->AppendSwitch(switches::kEnablePanels);
   }
 };
 
 // TODO(jianli): Enable it when Panel::CreateNativePanel is implemented.
 IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, DISABLED_WindowOpenPanel) {
   ASSERT_TRUE(RunExtensionTest("window_open/panel")) << message_;
 }