Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 7042003: Revert 85732 (broke build) - Move SystemMonitor to base/. (Closed)

Created:
9 years, 7 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, achuith+watch_chromium.org, amit, brettw-cc_chromium.org, jam, Aaron Boodman, rginda+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, native-client-reviews_googlegroups.com, Erik does not do reviews
Visibility:
Public.

Description

Revert 85732 (broke build) - Move SystemMonitor to base/. I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7015017 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -529 lines) Patch
M app/app.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M app/app_base.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M base/base.gyp View 2 chunks +1 line, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
D base/system_monitor/system_monitor.h View 1 chunk +0 lines, -142 lines 0 comments Download
D base/system_monitor/system_monitor.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D base/system_monitor/system_monitor_mac.mm View 1 chunk +0 lines, -78 lines 0 comments Download
D base/system_monitor/system_monitor_posix.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D base/system_monitor/system_monitor_unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D base/system_monitor/system_monitor_win.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/browser/browser_main.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_event_router_forwarder_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/nacl/nacl_main.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/utility_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/hi_res_timer_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/hi_res_timer_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/worker/worker_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/widget_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
willchan no longer on Chromium
9 years, 7 months ago (2011-05-18 07:14:02 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698