Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Issue 7015017: Move SystemMonitor to base/. (Closed)

Created:
9 years, 7 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move SystemMonitor to base/. I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85732 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85737 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85740

Patch Set 1 #

Patch Set 2 : Fix Nacl build. #

Patch Set 3 : Fix windows build and merge. #

Patch Set 4 : Stop using Cocoa for Mac power notifications. #

Patch Set 5 : Add comment. #

Patch Set 6 : Oops, didn't scp everything. #

Patch Set 7 : Fix CF build. #

Patch Set 8 : Fix copyright. #

Patch Set 9 : Merge #

Patch Set 10 : Fix merged test. #

Patch Set 11 : Add BASE_API.wq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/system_monitor/system_monitor.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
Hey Brett, Here's the move. I have to figure out how to resolve some Mac ...
9 years, 7 months ago (2011-05-12 07:39:31 UTC) #1
brettw
LGTM
9 years, 7 months ago (2011-05-12 15:57:58 UTC) #2
willchan no longer on Chromium
+avi Turns out I had to gut the SystemMonitor implementation for OS X due to ...
9 years, 7 months ago (2011-05-14 17:41:06 UTC) #3
Avi (use Gerrit)
LGTM
9 years, 7 months ago (2011-05-18 04:07:32 UTC) #4
commit-bot: I haz the power
9 years, 7 months ago (2011-05-18 06:46:30 UTC) #5
Can't process patch for file base/system_monitor/system_monitor.cc.
A +

Powered by Google App Engine
This is Rietveld 408576698